wip

sebastienros · Mar 9, 2022 · 106430e · 106430e
1 parent e2239d3
commit 106430e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 44 deletions.
diff --git a/Jint.Tests.Test262/test/skipped.json b/Jint.Tests.Test262/test/skipped.json
@@ -209,26 +209,6 @@
         "reason": "inner binding rejects modification (from parameters) Expected a Error to be thrown but no exception was thrown at all"
     },
 
-    {
-        "source": "built-ins/TypedArrayConstructors/ctors-bigint/object-arg/as-generator-iterable-returns.js",
-        "reason": "yield not implemented"
-    },
-    {
-        "source": "built-ins/TypedArrayConstructors/ctors-bigint/object-arg/iterating-throws.js",
-        "reason": "yield not implemented"
-    },
-    {
-        "source": "language/expressions/object/accessor-name-computed-yield-id.js",
-        "reason": "accessor / yield not implemented"
-    },
-    {
-        "source": "language/expressions/object/accessor-name-computed.js",
-        "reason": "yield not implemented"
-    },
-    {
-        "source": "built-ins/TypedArrayConstructors/ctors/object-arg/as-generator-iterable-returns.js",
-        "reason": "yield not implemented"
-    },
     {
         "source": "language/expressions/object/prop-dup-set-get-set.js",
         "reason": "accessor not implemented"
@@ -298,27 +278,6 @@
         "reason": "not implemented: Creation of new variable environment for the function body (as distinct from that for the function's parameters)"
     },
 
-    {
-        "source": "built-ins/Object/prototype/toString/proxy-function.js",
-        "reason": "generators not implemented"
-    },
-    {
-        "source": "language/statements/class/subclass/builtin-objects/GeneratorFunction/instance-prototype.js",
-        "reason": "generators not implemented"
-    },
-    {
-        "source": "language/statements/class/subclass/builtin-objects/GeneratorFunction/regular-subclassing.js",
-        "reason": "generators not implemented"
-    },
-    {
-        "source": "language/module-code/instn-local-bndng-export-gen.js",
-        "reason": "generators not implemented"
-    },
-    {
-        "source": "language/module-code/instn-local-bndng-gen.js",
-        "reason": "generators not implemented"
-    },
-
     // Eval problems
 
     {
@@ -343,6 +302,10 @@
 
     // Esprima problems
 
+    {
+        "source": "built-ins/GeneratorFunction/instance-yield-expr-in-param.js",
+        "reason": "Esprima doesn't detect invalid yield param"
+    },
     {
         "source": "language/expressions/object/method-definition/name-super-prop-param.js",
         "reason": "Esprima problem"

diff --git a/Jint/Runtime/Interpreter/Statements/JintExportDefaultDeclaration.cs b/Jint/Runtime/Interpreter/Statements/JintExportDefaultDeclaration.cs
@@ -49,7 +49,7 @@ protected override Completion ExecuteInternal(EvaluationContext context)
         JsValue value;
         if (_classDefinition is not null)
         {
-            value = _classDefinition.BuildConstructor(context, env);
+            value = _classDefinition.BuildConstructor(context, env).Value;
             var classBinding = _classDefinition._className;
             if (classBinding != null)
             {
@@ -93,4 +93,4 @@ private void InitializeBoundName(string name, JsValue value, EnvironmentRecord?
             ExceptionHelper.ThrowNotImplementedException();
         }
     }
-}
+}
diff --git a/Jint/Runtime/Interpreter/Statements/JintForInForOfStatement.cs b/Jint/Runtime/Interpreter/Statements/JintForInForOfStatement.cs
@@ -282,6 +282,11 @@ private Completion BodyEvaluation(
                     if (result.Type != CompletionType.Continue || (result.Target != null && result.Target != _statement?.LabelSet?.Name))
                     {
                         completionType = result.Type;
+                        if (iterationKind == IterationKind.Enumerate)
+                        {
+                            // TODO make sure we can start from where we left off
+                            //return result;
+                        }
                         if (result.IsAbrupt())
                         {
                             close = true;

diff --git a/Jint/Runtime/Modules/SourceTextModuleRecord.cs b/Jint/Runtime/Modules/SourceTextModuleRecord.cs
@@ -306,7 +306,8 @@ protected override void InitializeEnvironment()
                 var fn = d.Id?.Name ?? "*default*";
                 var fd = new JintFunctionDefinition(_engine, d);
                 env.CreateMutableBinding(fn, true);
-                var fo = realm.Intrinsics.Function.InstantiateFunctionObject(fd, env);
+                // TODO private scope
+                var fo = realm.Intrinsics.Function.InstantiateFunctionObject(fd, env, privateScope: null);
                 if (fn == "*default*") fo.SetFunctionName("default");
                 env.InitializeBinding(fn, fo);
             }