-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylesheet selector #95
Open
Riduidel
wants to merge
6
commits into
sebsauvage:master
Choose a base branch
from
Riduidel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation "simply" read the list of CSS from any fork of the excellent https://github.com/nodiscc/shaarli-themes theme repository. This reading is done through Javascript, and the selection is then downloaded from client. Now one should only think about commiting its CSS to the repository. THis implementation however lacks some "guification" to have it beautiful.
Notice that the style list is automatically reloaded when repository address is changed.
text field for repo selection has been removed, and image has been put in a location that doesn't suck (too much)
@Riduidel there's a proposition for themes management at shaarli#22 |
pikzen
pushed a commit
to pikzen/Shaarli
that referenced
this pull request
Mar 29, 2015
Relates to sebsauvage#71 Relates to sebsauvage#95 Additions: - Makefile for easy usage, - Composer file to declare dev & test dependencies. Features: - PHP Copy/Paste Detect: detect duplicate code; - PHP Code Sniffer: static analysis, syntax checking, - PHP Mess Detector: static analysis, syntax checking. Signed-off-by: VirtualTam <[email protected]>
fanch317
pushed a commit
to fanch317/Shaarli
that referenced
this pull request
Jul 26, 2015
Relates to sebsauvage#95, sebsauvage#218 Signed-off-by: VirtualTam <[email protected]>
fanch317
pushed a commit
to fanch317/Shaarli
that referenced
this pull request
Sep 1, 2015
…andards Relates to sebsauvage#95 Usage - list available standards $ ./vendor/bin/phpcs -i - run PHPCS against a given standard $ make PHPCS_<standard> Examples $ make PHPCS_PSR1 $ make PHPCS_Zend Signed-off-by: VirtualTam <[email protected]>
fanch317
pushed a commit
to fanch317/Shaarli
that referenced
this pull request
Apr 20, 2016
Relates to sebsauvage#95 Customizations for PHP/Shaarli: - add project information - index PHP files - index global functions - exclude directories Usage $ make doxygen $ firefox doxygen/index.html & Notes - classes can be found under "Data Structures" - global functions can be found under "Files > Globals > Functions" Signed-off-by: VirtualTam <[email protected]>
sijnak
pushed a commit
to sijnak/Shaarli
that referenced
this pull request
Nov 26, 2016
Relates to sebsauvage#95 Signed-off-by: VirtualTam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stylesheet selector closes #93 by allowing users to apply any stylesheet defined in https://github.com/nodiscc/shaarli-themes, provided this stylesheet is defined using a user.css (ONLY this file will be copied to local shaarli install). Notice that, if stylesheet defines a home.png file, this file will be displayed in shaarli configuration panel as a stylesheet preview.