Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Analyze Compile Flags #3321

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

AiraYumi
Copy link
Contributor

Adds compilation options for debugging.

@github-actions github-actions bot added the cmake label Dec 27, 2024
@@ -199,6 +207,10 @@ if (DARWIN)
# required for clang-15/xcode-15 since our boost package still uses deprecated std::unary_function/binary_function
# see https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#C++-Standard-Library
add_compile_definitions(_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION)

if (CMAKE_BUILD_TYPE REGEX "RelWithDebInfo")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac build fails here. Should it be if( CMAKE_BUILD_TYPE MATCHES "RelWithDebInfo" )?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RyeMutt
Copy link
Contributor

RyeMutt commented Jan 2, 2025

#3071 Also introduces support for sanitizers which I hope to have ready to merge soon.

Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyeMutt, since your change is not ready yet, can we merge this now?

@marchcat marchcat merged commit fdf41a9 into secondlife:develop Jan 6, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants