#3332 Fix buffers not accounting for dynamic cache values #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akleshchev
commented
Feb 11, 2025
akleshchev
commented
- Fix previous lapse of judgement with GLYPH_BATCH_SIZE
- We record width/height once per string rendering, but values are actually dynamic and additing new symbols invalidates them. Added mLastFontGlyphCount to track addition of new symbols. Likely not the best way to handle the issue, but we can fix rendering later, mLastFontGlyphCount should be safe in scope of foreverFPS.
And fix previous lapse of judgement with GLYPH_BATCH_SIZE
marchcat
approved these changes
Feb 11, 2025
maxim-productengine
approved these changes
Feb 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.