Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep GHA Fix] Fix failing GitHub Actions on main branch #64

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Sweep GHA Fix] Fix failing GitHub Actions on main branch #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b39dcb
feat: Updated docs/BuildSource.md
sweep-ai[bot] Feb 1, 2024
5cafa24
feat: Updated docs/BuildSource.md
sweep-ai[bot] Feb 1, 2024
7f233e4
feat: Updated CONTRIBUTING.md
sweep-ai[bot] Feb 1, 2024
8736aa4
feat: Updated CONTRIBUTING.md
sweep-ai[bot] Feb 1, 2024
04e6a39
Merge main into sweep/fix-gha-failure_51db0
sweep-ai[bot] Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ cd timescaledb

* Hack away. Add tests for non-trivial changes.

* Run the [test suite](#testing) and make sure everything passes.
* Run the [test suite](#testing) and make sure everything passes **before you open a pull request**.

* When committing, be sure to write good commit messages according to [these
seven rules](https://chris.beams.io/posts/git-commit/#seven-rules). Doing
Expand Down Expand Up @@ -99,7 +99,7 @@ cd timescaledb
request, either mention them (preferably by GitHub name) in the PR's
body or [assign them as a reviewer](https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/).

* If you get a test failure in the CI, check them under [Github Actions](https://github.com/timescale/timescaledb/actions)
* If you get a test failure in the CI, check them under [Github Actions](https://github.com/timescale/timescaledb/actions).

* Address feedback by amending your commit(s). If your change contains
multiple commits, address each piece of feedback by amending that
Expand All @@ -118,8 +118,7 @@ Please check that the full test suite (including your test additions
or changes) passes successfully on your local machine **before you
open a pull request**.

If you are running locally:
```bash
If you are running locally, execute the following commands to run the test suite:
# Use Debug build mode for full battery of tests

# Build the project in Debug mode
Expand All @@ -130,7 +129,6 @@ cd ..
./bootstrap -DCMAKE_BUILD_TYPE=Debug
cd build && make
make installcheck
```

All submitted pull requests are also automatically
run against our test suite via [Github Actions](https://github.com/timescale/timescaledb/actions)
Expand Down
6 changes: 6 additions & 0 deletions docs/BuildSource.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ git checkout 2.5.0
cd build && make
# To install
make install
make installcheck
# To run the test suite
make installcheck
make install
```

Note, if you have multiple versions of PostgreSQL installed you can specify the path to `pg_config`
Expand Down Expand Up @@ -70,3 +74,5 @@ cmake --build ./build --config Release --target install
# Alternatively, build in Visual Studio via its built-in support for
# CMake or by opening the generated build/timescaledb.sln solution file.
```
# To run the test suite
make installcheck
Loading