Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deployment script #103

Closed
wants to merge 19 commits into from
Closed

feat: add deployment script #103

wants to merge 19 commits into from

Conversation

mennatnaga
Copy link
Contributor

Puts all deployment commands in one script

Related PRs and Issues

Closes #102

gluax
gluax requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@gluax gluax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but let's try to have less repeated logic so we can make changes only in a few places rather than many.

scripts/deploy.sh Outdated Show resolved Hide resolved
scripts/deploy.sh Outdated Show resolved Hide resolved
scripts/deploy.sh Outdated Show resolved Hide resolved
scripts/deploy.sh Outdated Show resolved Hide resolved
scripts/query_dr_contract_address.sh Outdated Show resolved Hide resolved
scripts/query_dr_contract_address.sh Outdated Show resolved Hide resolved
scripts/query_dr_contract_address.sh Outdated Show resolved Hide resolved
scripts/query_executor.sh Show resolved Hide resolved
scripts/resgister_executor.sh Outdated Show resolved Hide resolved
@mennatnaga mennatnaga force-pushed the feat/deployment-script branch from 8a1e400 to 4c4fa64 Compare November 23, 2023 02:28
@mennatnaga mennatnaga requested a review from gluax November 23, 2023 02:29
@mennatnaga mennatnaga changed the base branch from main to testnet-2 November 23, 2023 04:33
gluax
gluax approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@gluax gluax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor rust thing I missed the first time. But the shell scripts look much cleaner!

packages/data-requests/src/utils.rs Outdated Show resolved Hide resolved
packages/data-requests/src/helpers.rs Outdated Show resolved Hide resolved
jamesondh
jamesondh suggested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jamesondh jamesondh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but can you change the branch to merge into feat/add-rand-seed instead of testnet-2? That way it makes it easier to see how this PR is different from the previous one. Then once feat/add-rand-seed is merged and the branch is deleted, GitHub will automatically change the branch on this PR back to testnet-2

scripts/resgister_executor.sh Outdated Show resolved Hide resolved
@mennatnaga mennatnaga changed the base branch from testnet-2 to feat/add-rand-seed December 4, 2023 10:05
@mennatnaga mennatnaga requested a review from jamesondh December 4, 2023 10:06
@mennatnaga mennatnaga force-pushed the feat/deployment-script branch from 5b87b85 to 7c5c581 Compare December 6, 2023 16:43
@jamesondh jamesondh marked this pull request as draft December 21, 2023 18:44
@jamesondh jamesondh changed the base branch from feat/add-rand-seed to testnet-2 March 21, 2024 19:21
@jamesondh jamesondh closed this Mar 22, 2024
@gluax gluax deleted the feat/deployment-script branch May 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluax gluax gluax approved these changes

@FranklinWaller FranklinWaller Awaiting requested review from FranklinWaller

@hacheigriega hacheigriega Awaiting requested review from hacheigriega

@jamesondh jamesondh Awaiting requested review from jamesondh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Create a shell script to deploy all contracts
3 participants
@mennatnaga @jamesondh @gluax