✨ Disallow new commits during reveal stage (after replication factor is met) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Nov 29, 2023
| @@ -49,6 +49,13 @@ pub mod data_request_results { | |||
| if dr.commits.contains_key(&sender.to_string()) { | |||
| return Err(AlreadyCommitted); | |||
| } | |||
|
|
|||
| // error if reveal stage has started (replication factor reached) | |||
| if u16::try_from(dr.commits.len()).unwrap() >= dr.replication_factor { | |||
There was a problem hiding this comment.
This unwrap scares me a bit. Although Ig, in that case, the contract crashes, it doesn't impact the chain.
There was a problem hiding this comment.
Does it make sense to replace the unwrap with an if let/match or at least with an except(message)?
There was a problem hiding this comment.
We could write our own message. Or I think we use anyhow to have every function return an anyhow::Result and use the ? operator. Anyhow, IMO, is acceptable in non-user-facing applications or in instances where the user is technically sufficient.
mennatnaga
approved these changes
Dec 1, 2023
mariocao
approved these changes
Dec 15, 2023
jamesondh
force-pushed
the
feat/disallow-commits-after-reveal
branch
from
6d05782 to
4b242cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Once the replication factor is met, new commits should not be allowed to avoid freeloading revealed answers from data request executors.
Explanation of Changes
Created new error and add it to
commit_resultfunction, trigger it if replication factor is metTesting
Updated integration test to check the condition. Without the updated contract code, the test fails.
Related PRs and Issues
Closes #104