Refactor(data-requests): pad hashes #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesondh
approved these changes
Mar 24, 2024
mariocao
reviewed
Mar 25, 2024
mariocao
reviewed
Mar 25, 2024
| @@ -59,7 +59,7 @@ pub fn calculate_dr_id_and_args( | |||
| tally_binary_id: tally_binary_id.clone(), | |||
| dr_inputs: dr_inputs.clone(), | |||
| tally_inputs: tally_inputs.clone(), | |||
| memo: memo.clone(), | |||
| memo: memo.clone().try_into().unwrap(), | |||
There was a problem hiding this comment.
memo should be Bytes and not a Hash.
In that way, we don't need to use that unwrap.
There was a problem hiding this comment.
I just noticed we already have a Memo type, so I used it.
mariocao
reviewed
Mar 25, 2024
mariocao
reviewed
Mar 25, 2024
mennatnaga
force-pushed
the
refactor/pad-hashes2
branch
2 times, most recently
from
5b23f72 to
f79fa57
Compare
mariocao
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
As discussed with @jamesondh , approving for later updating due to the changes to DR specs 😅
jamesondh
force-pushed
the
refactor/pad-hashes2
branch
from
f79fa57 to
779109a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
All this work was done by Jameson #116, but we decided to redo it because he forked from a branch that we decided not to merge, so rebasing his PR was very hard.
Motivation
Update the data request hashing function to match the current EVM function.
Explanation of Changes
Used alloy library to pad variable length inputs in hashing function for data request hashes.
Testing
Compared data request hashes to
testHashfunction in EVM contracts' latest commit, which uses identical arguments to produce an identical hash.Related PRs and Issues
Created in response to this PR for EVM: sedaprotocol/seda-evm-contracts#23
Data result ID hashes are currently not matching tthe EVM contracts, see related issue: #115