Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ rename verify_ functions to check_ #918

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

signekb
Copy link
Member

@signekb signekb commented Dec 17, 2024

Description

This PR renames the verify_ functions to check_.
(ignoring the "old" functions verifying properties using frictionless-py. I'll remove them in a separate PR)

Closes #860

This PR needs a quick review.

@signekb signekb requested a review from a team as a code owner December 17, 2024 14:02
martonvago
martonvago previously approved these changes Dec 17, 2024
Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from refactor/move-check-tests-to-checks-folder to main December 18, 2024 18:53
@lwjohnst86 lwjohnst86 dismissed martonvago’s stale review December 18, 2024 18:53

The base branch was changed.

@lwjohnst86 lwjohnst86 merged commit 986e3f0 into main Dec 18, 2024
3 checks passed
@lwjohnst86 lwjohnst86 deleted the refactor/rename-verify-functions-to-check branch December 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Convert all verify functions to check_
3 participants