Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 explain that we follow Seedcase's overall design #936

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

lwjohnst86
Copy link
Member

Description

This PR adds a very small edit to the design landing page to explain that we follow principles and patterns (that will eventually be written) found in the design repo.

This PR needs a quick review.

Checklist

  • Added or updated tests
  • Updated documentation
  • Ran just run-all

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner January 3, 2025 15:41
@signekb
Copy link
Member

signekb commented Jan 6, 2025

@lwjohnst86 seems like there's some changed here related to #935. Should this be a stacked PR instead?

@lwjohnst86
Copy link
Member Author

I am not sure what happened to this branch 🤔 😕

@lwjohnst86 lwjohnst86 marked this pull request as draft January 6, 2025 12:56
@lwjohnst86 lwjohnst86 changed the base branch from main to chore/rename-root-to-global January 6, 2025 13:55
@lwjohnst86 lwjohnst86 marked this pull request as ready for review January 6, 2025 13:55
@lwjohnst86 lwjohnst86 requested a review from signekb January 9, 2025 10:17
martonvago
martonvago previously approved these changes Jan 10, 2025
Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Base automatically changed from chore/rename-root-to-global to main January 10, 2025 12:46
@lwjohnst86 lwjohnst86 dismissed martonvago’s stale review January 10, 2025 12:46

The base branch was changed.

@lwjohnst86 lwjohnst86 merged commit 68f7ca9 into main Jan 10, 2025
1 of 2 checks passed
@lwjohnst86 lwjohnst86 deleted the docs/update-design-landing-page branch January 10, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants