Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ♻️ path_package_properties() -> path_properties() #996

Merged
merged 1 commit into from
Jan 24, 2025
Merged

refactor: ♻️ path_package_properties() -> path_properties() #996

merged 1 commit into from
Jan 24, 2025

Conversation

signekb
Copy link
Member

@signekb signekb commented Jan 23, 2025 •
edited
Loading

Description

We don't have other properties files (like e.g., resource properties files), so we might as well just call it path_properties

This PR needs a quick review.

Checklist

  • Added or updated tests
  • Ran just run-all

@signekb signekb marked this pull request as ready for review January 23, 2025 15:00
@signekb signekb requested a review from a team as a code owner January 23, 2025 15:00
martonvago
martonvago approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@lwjohnst86 lwjohnst86 merged commit 0976a3e into main Jan 24, 2025
4 checks passed
@lwjohnst86 lwjohnst86 deleted the refactor/rename-function-to-path-properties branch January 24, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martonvago martonvago martonvago approved these changes

@lwjohnst86 lwjohnst86 lwjohnst86 approved these changes

Assignees

@signekb signekb

Labels
None yet
Projects
Team project planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@signekb @lwjohnst86 @martonvago