Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ output everything from code cells in Reference docs #997

Merged
merged 16 commits into from
Jan 24, 2025

Conversation

signekb
Copy link
Member

@signekb signekb commented Jan 24, 2025

Description

This PR adds the setting ipynb-shell-interactivity: all in a yml header in all Reference docs.
This ensures that all output from the cell is printed below it.

It also makes the output: true setting in all example cells redundant.

This PR needs a quick review.

Checklist

  • Updated documentation
  • Ran just run-all

signekb and others added 15 commits January 16, 2025 15:04
So the examples will run correctly. If `create_resource_properties` is run before `create_resource_structure` the example will fail bc the resource structure doesn't exist yet.
There's no output of this code chunk, so it's not needed.
By moving `write_resource_properties` down.
This adds a yml header with the setting`ipynb-shell-interactivity: all` to get all output from example cells in the reference docs.
When we have added `ipynb-shell-interactivity: all` at the top of the document.
@signekb signekb requested a review from a team as a code owner January 24, 2025 11:41
Base automatically changed from docs/add-examples-to-user-facing-functions to main January 24, 2025 14:13
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand that render code, but if it works then 👍

@lwjohnst86 lwjohnst86 merged commit 3fcfa96 into main Jan 24, 2025
3 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/output-everythin-in-reference-docs-examples branch January 24, 2025 14:15
@lwjohnst86
Copy link
Member

Jumped the gun here. This shouldn't be a feat, this is docs or chore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants