xWidthAvg: Update character frequency weightings data source #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9161d71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
Feb 9, 2024
Co-authored-by: Adam Skoufis <[email protected]>
michaeltaranto
force-pushed
the
metrics-frequency-data
branch
from
a35dcee to
fd89e07
Compare
askoufis
reviewed
Feb 15, 2024
askoufis
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Character frequency weightings used to calculate the
xWidthAvgmetrics were previously hard coded internally, and were an adaption from a frequency table on Wikipedia.We now generate these weightings based on the abstracts of WikiNews articles, making it possible to add support for other languages that make use of non-latin unicode subsets, e.g. Thai.
The updated
xWidthAvgmetrics are very close to the original hard coded values.This results in either no or extremely minor changes to the generated fallback font CSS, meaning we don't expect any notable changes to consumers, with the benefit being this lays the ground work to support additional language subsets in the future.
Note for the reviewer
This PR is in preparation for a follow up PR that introduces unicode subset support. So some refactoring in this PR is in service of a cleaner diff for the next PR.