Implement Get mentors by category endpoint (Admin) #26 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e2416f6.
|
@anjula-sack please review this |
anjula-sack
reviewed
Oct 24, 2023
src/services/admin/mentor.service.ts
Outdated
Comment on lines
129
to
138
| .select([ | ||
| 'mentor.uuid', | ||
| 'category.category', | ||
| 'mentor.application', | ||
| 'profile.contact_email', | ||
| 'profile.first_name', | ||
| 'profile.last_name', | ||
| 'profile.image_url', | ||
| 'profile.linkedin_url' | ||
| ]) |
There was a problem hiding this comment.
Without selecting fields, what does it return? @sathudeva7 Also can you drop a comment on the issue and get assigned?
There was a problem hiding this comment.
sorry for the mistake could you please assign me to this issue
There was a problem hiding this comment.
without selecting fields ->
There was a problem hiding this comment.
@sathudeva7 Can you drop a comment on the issue then I will assign you
There was a problem hiding this comment.
@sathudeva7 Can you update it to without selecting?
There was a problem hiding this comment.
i will update within this week
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #26
Goals
This issue involves implementing an API to get mentors by category. The endpoint should allow Admin to make a GET request to {{baseUrl}}/api/admin/mentors?category={{category}}.
Approach
const mentors: Mentor[] = await mentorRepository .createQueryBuilder('mentor') .innerJoinAndSelect('mentor.category', 'category') .leftJoinAndSelect('mentor.profile', 'profile') .select([ 'mentor.uuid', 'category.category', 'mentor.application', 'profile.contact_email', 'profile.first_name', 'profile.last_name', 'profile.image_url', 'profile.linkedin_url' ]) .where('category.category ILIKE :name', { name: categoryQuery }) .getMany()Screenshots
Checklist
Related PRs
Test environment
Learning