Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR adds port mapping for the application and database service #87

Merged
merged 13 commits into from
Jan 6, 2024

Conversation

mayura-andrew
Copy link
Member

Purpose

The purpose of this PR is to fix #86

Goals

This PR adds port mapping for the application and database services in the docker-compose.yml file. It also updates the README.md file with instructions on how to connect to the application and database using the mapped ports.

Approach

I've updated the docker-compose.yml file to include port mappings for the application and database services. I've also updated the README.md file with instructions on how to use these port mappings to connect to the application and database.

Screenshots

N/A

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

N/A

Test environment

This feature was tested on Docker Desktop 4.26.1 and, build on Fedora Linux 39 (KDE Plasma) x86_64

Learning

I've learned more about Docker port mapping and how it allows applications running inside Docker containers to be accessed from the host machine.

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayura-andrew There are some conflicts can you fix them?

Copy link
Member Author

@mayura-andrew mayura-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed conflicts

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @mayura-andrew

@anjula-sack anjula-sack merged commit 7f87fbc into sef-global:main Jan 6, 2024
1 check failed
anjula-sack pushed a commit to anjula-sack/scholarx-backend that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To add port mapping to the app service in docker-compose.yml file
2 participants