-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR adds port mapping for the application and database service #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayura-andrew There are some conflicts can you fix them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @mayura-andrew
Purpose
The purpose of this PR is to fix #86
Goals
This PR adds port mapping for the application and database services in the
docker-compose.yml
file. It also updates theREADME.md
file with instructions on how to connect to the application and database using the mapped ports.Approach
I've updated the
docker-compose.yml
file to include port mappings for the application and database services. I've also updated theREADME.md
file with instructions on how to use these port mappings to connect to the application and database.Screenshots
N/A
Checklist
Related PRs
N/A
Test environment
This feature was tested on Docker Desktop 4.26.1 and, build on Fedora Linux 39 (KDE Plasma) x86_64
Learning
I've learned more about Docker port mapping and how it allows applications running inside Docker containers to be accessed from the host machine.