Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmarks): set correct group members for v4 #12

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Jun 25, 2024

Description

This PR fixes a bug in the function to generate V4 stats and updates the Semaphore V4 dependency.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cedoor cedoor requested a review from a team as a code owner June 25, 2024 14:34
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semaphore-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:38pm

@cedoor cedoor merged commit 0f81734 into main Jun 26, 2024
4 checks passed
@cedoor cedoor deleted the fix/v4-group branch June 26, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants