Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(contracts): update visibility of some functions #17

Merged
merged 1 commit into from
Aug 28, 2024
Merged

refactor(contracts): update visibility of some functions #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/contracts/contracts/SemaphoreVoting.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ contract SemaphoreVoting is ISemaphoreVoting {
}

/// @dev See {ISemaphoreVoting-createPoll}.
function createPoll(address coordinator) public {
function createPoll(address coordinator) external override {
uint256 groupId = semaphore.createGroup();

polls[groupId].coordinator = coordinator;
Expand All @@ -40,7 +40,7 @@ contract SemaphoreVoting is ISemaphoreVoting {
}

/// @dev See {ISemaphoreVoting-addVoter}.
function addVoter(uint256 pollId, uint256 identityCommitment) public onlyCoordinator(pollId) {
function addVoter(uint256 pollId, uint256 identityCommitment) external override onlyCoordinator(pollId) {
if (polls[pollId].state != PollState.Created) {
revert SemaphoreVoting__PollHasAlreadyBeenStarted();
}
Expand All @@ -49,7 +49,7 @@ contract SemaphoreVoting is ISemaphoreVoting {
}

/// @dev See {ISemaphoreVoting-startPoll}.
function startPoll(uint256 pollId, uint256 encryptionKey) public override onlyCoordinator(pollId) {
function startPoll(uint256 pollId, uint256 encryptionKey) external override onlyCoordinator(pollId) {
if (polls[pollId].state != PollState.Created) {
revert SemaphoreVoting__PollHasAlreadyBeenStarted();
}
Expand All @@ -67,7 +67,7 @@ contract SemaphoreVoting is ISemaphoreVoting {
uint256 nullifier,
uint256 merkleTreeRoot,
uint256[8] calldata proof
) public {
) external override {
if (polls[pollId].state != PollState.Ongoing) {
revert SemaphoreVoting__PollIsNotOngoing();
}
Expand All @@ -86,7 +86,7 @@ contract SemaphoreVoting is ISemaphoreVoting {
}

/// @dev See {ISemaphoreVoting-endPoll}.
function endPoll(uint256 pollId, uint256 decryptionKey) public override onlyCoordinator(pollId) {
function endPoll(uint256 pollId, uint256 decryptionKey) external override onlyCoordinator(pollId) {
if (polls[pollId].state != PollState.Ongoing) {
revert SemaphoreVoting__PollIsNotOngoing();
}
Expand Down