Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve explorer ux #20

Merged
merged 3 commits into from
Nov 28, 2024
Merged

feat: improve explorer ux #20

merged 3 commits into from
Nov 28, 2024

Conversation

vplasencia
Copy link
Member

Description

This PR:

  • Fixes filtered groups .
  • Adds loader to pages.
  • Adds website metadata.

Related Issue(s)

Re #1

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia vplasencia requested a review from a team as a code owner November 27, 2024 18:35
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semaphore-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 6:35pm

cedoor
cedoor approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! LGTM 👍🏽

@vplasencia vplasencia merged commit a0dcf4d into feat/add-explorer Nov 28, 2024
4 checks passed
@vplasencia vplasencia deleted the feat/improve-ux-explorer branch November 28, 2024 08:55
vplasencia added a commit that referenced this pull request Nov 28, 2024
@vplasencia @cedoor
feat: add new semaphore explorer to apps (#19)
317f6fe 
* feat: add new semaphore explorer to apps

re #1

* style(explorer): fix code style with prettier

* Update apps/explorer/LICENSE

Co-authored-by: Cedoor <[email protected]>

* Update apps/explorer/README.md

Co-authored-by: Cedoor <[email protected]>

* feat: improve explorer ux (#20)

* fix(explorer): fix filtered groups search

* feat(explorer): add loader to pages

* chore(explorer): add website metadata

---------

Co-authored-by: Cedoor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vplasencia @cedoor