fix: PGO swapping did not set non support to 0

semiotic-ai · May 1, 2023 · 144b9dd · 144b9dd
1 parent b6197f7
commit 144b9dd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/SemioticOpt.jl b/src/SemioticOpt.jl
@@ -6,6 +6,7 @@ using Accessors
 using Lazy
 using LinearAlgebra
 using Zygote
+using InvertedIndices
 
 abstract type OptAlgorithm end
 

diff --git a/src/pgo.jl b/src/pgo.jl
@@ -376,6 +376,7 @@ function bestswap(xinit::AbstractVector{T}, supports::AbstractMatrix{<:Integer},
 
     # Compute optimal swap
     _ = map(eachcol(xs), eachcol(supports), 1:npossibilities) do x, support, i  # In-place so don't need to return or assign
+        x[Not(support)] .= zero(T)
         v = swap!(x, support, f, fa)
         os[i] = selection(v)
         return nothing