Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: create tap_eip712_message, tap_receipts and tap_graph #268

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Jan 27, 2025

  • Move signed_message.rs to its own crate tap_eip712_message
  • Move tap-core/receipts to its own crate tap_receipts
  • Move WithTimestampAndValue and WithUniqueId to tap_receipts
  • Move EIP712SignedMessage implementation of WithTimestampAndValue and WithUniqueId to tap_receipts.
  • Create tap_graph crate and move receipt_sol.rs and rav.rs sol structs
  • Rename rav.rs to rav_request.rs
  • Reexport everything to have less breaking changes
  • Use tap_graph as optional dependency for memory feature flag.
  • Move errors to proper crates

@coveralls
Copy link

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 13014759326

Details

  • 61 of 68 (89.71%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 80.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_graph/src/lib.rs 7 8 87.5%
tap_receipt/src/checks.rs 5 8 62.5%
tap_receipt/src/lib.rs 6 9 66.67%
Totals Coverage Status
Change from base Build 12937774543: -0.2%
Covered Lines: 1053
Relevant Lines: 1302

💛 - Coveralls

@gusinacio gusinacio force-pushed the gustavo/crates-reorganization branch 10 times, most recently from 91be8de to 3051646 Compare January 27, 2025 20:01
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/crates-reorganization branch from 3051646 to 300f28a Compare January 27, 2025 20:10
@gusinacio gusinacio changed the title refactor!: new crates refactor!: create tap_eip712_message, tap_receipts and tap_graph Jan 27, 2025
@gusinacio gusinacio marked this pull request as ready for review January 27, 2025 20:58
suchapalaver
suchapalaver previously approved these changes Jan 27, 2025
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/crates-reorganization branch from bfefaba to c70bec1 Compare January 28, 2025 08:52
@gusinacio gusinacio force-pushed the gustavo/crates-reorganization branch 4 times, most recently from 224de8e to 70c3ce2 Compare January 28, 2025 11:36
@gusinacio gusinacio force-pushed the gustavo/crates-reorganization branch from c1f139b to 99e5a40 Compare January 28, 2025 15:30
Copy link
Contributor

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a couple things

tap_eip712_message/src/lib.rs Outdated Show resolved Hide resolved
tap_eip712_message/src/lib.rs Show resolved Hide resolved
tap_eip712_message/src/lib.rs Outdated Show resolved Hide resolved
@gusinacio gusinacio force-pushed the gustavo/crates-reorganization branch from 99e5a40 to 2a98fb0 Compare January 28, 2025 16:15
@gusinacio gusinacio merged commit 3d35cac into main Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants