feat: add horizon types to tap_graph #270
Conversation
gusinacio
force-pushed
the
gustavo/tap-graph-v2
branch
from
19f140c to
f323ed7
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/tap-graph-v2
branch
from
f323ed7 to
b7bd0da
Compare
Pull Request Test Coverage Report for Build 13020749107Details
💛 - Coveralls |
| sol! { | ||
| /// Holds information needed for promise of payment signed with ECDSA | ||
| /// | ||
| /// We use camelCase for field names to match the Ethereum ABI encoding | ||
| #[derive(Debug, Serialize, Deserialize, Eq, PartialEq)] | ||
| struct ReceiptAggregateVoucher { | ||
| /// Unique allocation id this RAV belongs to | ||
| address allocationId; | ||
| // The address of the payer the RAV was issued by | ||
| address payer; | ||
| // The address of the data service the RAV was issued to | ||
| address dataService; | ||
| // The address of the service provider the RAV was issued to | ||
| address serviceProvider; | ||
| // The RAV timestamp, indicating the latest TAP Receipt in the RAV | ||
| uint64 timestampNs; | ||
| // Total amount owed to the service provider since the beginning of the | ||
| // payer-service provider relationship, including all debt that is already paid for. | ||
| uint128 valueAggregate; | ||
| // Arbitrary metadata to extend functionality if a data service requires it | ||
| bytes metadata; | ||
| } | ||
| } |
There was a problem hiding this comment.
@gusinacio could you just explain why this needs to be abi encoded, presumably because this is interacting with a contract. Would be great to be able to make the link here. Can also do it in a subsequent PR if you wanna explain here quickly 👍
There was a problem hiding this comment.
Definition of encodeType.
https://eips.ethereum.org/EIPS/eip-712#definition-of-domainseparator
https://docs.rs/alloy/latest/alloy/sol_types/macro.sol.html
sol macro generates the encodeType for EIP712, it doesn't use serde and at the time, there was no way to "rename camelCase" like we do in serde
There was a problem hiding this comment.
it looks like it still doesn't have that alloy-rs/core#570
| receipts: &[Eip712SignedMessage<Receipt>], | ||
| previous_rav: Option<Eip712SignedMessage<Self>>, | ||
| ) -> Result<Self, AggregationError> { | ||
| //TODO(#29): When receipts in flight struct in created check that the state |
There was a problem hiding this comment.
| //TODO(#29): When receipts in flight struct in created check that the state | |
| //TODO(#29): When receipts in flight struct in created check that the state |
I don't understand what this is trying to say, can we make the TODO clearer, please! 🙏
| fn get_current_timestamp_u64_ns() -> Result<u64, SystemTimeError> { | ||
| Ok(SystemTime::now().duration_since(UNIX_EPOCH)?.as_nanos() as u64) | ||
| } | ||
| impl Receipt { |
There was a problem hiding this comment.
| impl Receipt { | |
| impl Receipt { |
There was a problem hiding this comment.
Maybe you could add a clippy lint rule in a following PR so it formats automatically like you are suggesting.
| // Check that nonces are different | ||
| // Note: This test has an *extremely low* (~1/2^64) probability of false failure, if a failure happens | ||
| // once it is not neccessarily a sign of an issue. If this test fails more than once, especially | ||
| // in a short period of time (within a ) then there may be an issue with randomness |
There was a problem hiding this comment.
| // in a short period of time (within a ) then there may be an issue with randomness | |
| // in a short period of time (within a ) then there may be an issue with randomness |
"within a "...?
v2feature flag (unstable for now)For now, handling both receipts is delegated to the lib user but serialization might be added in a future PR.