Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create forrestrie-examples crate to fix circular dependency #23

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: create forrestrie-examples crate to fix circular dependency #23

merged 1 commit into from
Oct 23, 2024

Conversation

suchapalaver
Copy link
Contributor

@suchapalaver suchapalaver self-assigned this Oct 23, 2024
@linear Linear
Copy link

linear bot commented Oct 23, 2024

BACK-102 Create repo for forrestrie examples

The examples for forrestrie awkwardly use both firehose-client (which also uses firehose-protos and firehose-protos, creating a circular dependency.

Like with integration tests where, for example at Edge & Node, a separate crate can be used to create integration test suites without circular dependencies, we can make a separate crate for our examples.

reviewer: anirudh

@suchapalaver suchapalaver force-pushed the joseph/back-102-create-repo-for-forrestrie-examples branch from b4d0c75 to ede2fa6 Compare October 23, 2024 17:04
@suchapalaver suchapalaver force-pushed the joseph/back-102-create-repo-for-forrestrie-examples branch from ede2fa6 to be51839 Compare October 23, 2024 17:14
@suchapalaver suchapalaver force-pushed the joseph/back-102-create-repo-for-forrestrie-examples branch from be51839 to 64d495c Compare October 23, 2024 17:16
gusinacio
gusinacio approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suchapalaver suchapalaver merged commit 6b704d9 into main Oct 23, 2024
8 checks passed
@suchapalaver suchapalaver deleted the joseph/back-102-create-repo-for-forrestrie-examples branch October 23, 2024 18:40
suchapalaver added a commit that referenced this pull request Nov 28, 2024
@suchapalaver
Merge pull request #23 from semiotic-ai/joseph/tru-281-add-note-on-sf…
01ebd62 
…-protos-streamingfast-and-protobuffers

docs(README): add note on sf-protos and Streamingfast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

@anirudh2 anirudh2 Awaiting requested review from anirudh2

Assignees

@suchapalaver suchapalaver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suchapalaver @gusinacio