receipt inclusion proof #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
requested changes
Oct 23, 2024
pedrohba1
changed the title
pedrohba1
force-pushed
the
pedro/back-20-receipt-inclusion-proof
branch
3 times, most recently
from
7ed8122 to
f79d611
Compare
…ofs in trie, sort dependencies alphabetically
…branch these are different topics and proof generation was already achieved in this branch
pedrohba1
force-pushed
the
pedro/back-20-receipt-inclusion-proof
branch
from
c933454 to
3afe47b
Compare
pedrohba1
force-pushed
the
pedro/back-20-receipt-inclusion-proof
branch
from
3afe47b to
6badc7f
Compare
I'm adding the example into another PR this is another task that relies on this. |
suchapalaver
requested changes
Nov 3, 2024
suchapalaver
reviewed
Nov 4, 2024
suchapalaver
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks for all the changes!
Couple of wishes for the future:
- go with creating tickets/issues instead of leaving
TODOnotes to self in the code. - unless they take too long, wait for the authors of comments to resolve them themselves.
- use
git rebaseto squash your commits down to a reasonable number. Should 5 or less commits per PR usually. It depends.
suchapalaver
added a commit
that referenced
this pull request
Nov 28, 2024
…-note-on-crates-to-repo-readme docs(README): add section on workspace crates
suchapalaver
pushed a commit
that referenced
this pull request
Nov 28, 2024
…on-proof receipt inclusion proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACK-20
This was reviewed previously in this PR from Forrestrie
What does it all do?
It covers the basic receipt proofs we need for the execution layer data, using the data extracted from firehose.
To be more precise, from this diagram of nozzle, it contains the functions defined in the diagram:
receipts_trie(Header,Receipts)merkle_proof(Trie, Receipt)Verify(Log, Header, Receipt)