refactor(firehose-protos): reorganize ethereum v1 module #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BACK-114 `firehose-protos`: create ethereum v1 module
Transition to a module with multiple submodules to anticipate code moved from |
suchapalaver
requested review from
gusinacio,
anirudh2,
pedrohba1 and
carlosvdr
suchapalaver
force-pushed
the
joseph/back-114-firehose-protos-create-ethereum-v1-module
branch
from
a83c70a to
3851398
Compare
gusinacio
approved these changes
Oct 25, 2024
suchapalaver
deleted the
joseph/back-114-firehose-protos-create-ethereum-v1-module
branch
suchapalaver
added a commit
that referenced
this pull request
Nov 28, 2024
…e-binary build(forrestrie): create forrestrie binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to review testing of public functions in
flat-files-decoder, we want to remove methods that could be implemented more readably and testably as conversions on the protobuffer types. These are allethereum_v1protobuffer types so this PR clears the way for that work by creating a clearerethereum_v1module structure.