Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cluster endpoint matching #6

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Improve cluster endpoint matching #6

merged 1 commit into from
Jun 3, 2024

Conversation

jjh-kim
Copy link
Contributor

@jjh-kim jjh-kim commented Jun 3, 2024

get_cluster_id function was designed to resolve RDS cluster identifier automatically
from given cluster endpoint (or DNS record pointing to cluster endpoint).
This PR corrects the implementation to align with the original intention.

Copy link
Contributor

@peterlyoo peterlyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjh-kim jjh-kim merged commit 340b83c into main Jun 3, 2024
2 checks passed
@jjh-kim jjh-kim added the bug Something isn't working label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants