-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move doc to master branch #289
Comments
Hi Tom, it's so long ago I can't remember why I did it that way - maybe to do with testing the website locally while I was learning. If you can streamline the process, go for it. |
I'm sure you've already looked at this... https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-github-pages-site I would have just been doing whatever was recommended at the time, I think... |
Ok, from what I have read around, the main interest of having the documentation in a separate branch is too avoid cluttering the git history of the main branch and keeping it clean. This is a bit defeated in our case as the doxygen doc, which are always generating huge changes are also in the I am not sure what is the best but I see two different ways of improving the current workflow: Keeping the
|
Another argument for docs in master is that it will be easier to handle code and documentation changes, synchronously, inside a single PR. That would have been nice to have while working on Mozzi 2.0.0. It may be worth investigating, what would be needed to automate the doxygen-run, entirely, however. I know it's possible in principle to create a github workflow that will generate/deploy the web-pages including both the jekyll and doxygen generation. Doing that would add two significant advantages (if it's not prohibitively difficult to implement):
|
This last option would indeed be ideal (maybe except for debugging the doxygen doc). I have figured that having a github action running Doxygen seems to be fairly straightforward (https://github.com/mattnotmitt/doxygen-action) but if I am correct, this still clutters diff if I am correct.
Indeed, all the needed changes, to doc, web, can be done in a working branch, alongside the work on the code, I did not think of that but that is a big plus IMO. |
I believe it will not be necessary for the action to commit the doxygen-generated files to the repository at all. Rather, we'd have to combine everything into an action / sequence of actions that:
|
I might be doing this wrong, but the way I am remaking the docs (and addition to the website), is to have have another folder synced on Mozzi's branch
gh-pages
.This implies, for any change in the library, to run doxygen on the main branch, to take into account the new sources, and then copy-paste the result in the
gh-pages
branch.I do not have a super clear idea about all this, but wouldn't it be simpler to deploy the website from a folder of the
master
branch?The text was updated successfully, but these errors were encountered: