-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic deployment of doxygen/gh-page on push on Master #291
Conversation
Added automatic documentation workflows Dummy commit to test workflow Retried another workflow Fixed typo in workflow Fixed typo in dox generation action Yet another try at deplay Typo Test another try anothen Correct working dir? anno Added doxygen to build and deply Correct Correct path to Doxyfile? Trying to find the correct folder Moved to dox directory Went a bit fast Another try Added platform on the gemfile Added correct platform Trying to fix setup ruby action Trying to fix jekyll Another try Reverted gemlock Another try Try another workflow Another Another Fixed upload artefact? Spaces, not tab Idem Another try Trying to fix the deploy Dummy commit Fixing doxygen Trying to fix images again Trying a fix of images
This reverts commit 84355b5.
This reverts commit 7a7b5f2.
This reverts commit ea480a5.
Ok, that seems to work, more or less, but I still have a problem with styling, as you can here. I think that it does take into account the I think overall, this might be easier to maintain: all is in the same branch, and generated on push on master, which allows to fix things before a release. All the html files are not in the repo anymore… What do you think? |
Updated, the custom style sheet doxygen.css is now taken into account, but does not look good IMO, reverted to black (default on the machine this is compiled on by gh-action). There might be a bit of possible cleanup, but my brain is a bit fried now fighting with actions… |
Dummy commit Default dox style
Wow, this is great! As for the CSS, I suggest not to worry too much, at least for the time being. The difference between API and "main" styling may be more prominent with the new defaults, but it's not like we had consistent style, before. One thing we may want to look into is a back link from the API section to the main website (but that's not a regression, either). Would the arduino-lint action be happy, if the gh-pages folder was moved to extras/doc? Or would it even be possible to drop the .ino files from within gh-pages, and copy them straight from the examples folder, as part of the workflow? |
Thanks! It was a bit of a traumatizing fight but I think it is a satisfying solution. The fact that the html will not be part of the repo is a good thing on the long run (except for this merge…). I learnt quite a bit in the process! Yes, arduino-lint did not like that, I have to admit that I initially did not care with it but looking a bit in details it indeed seems that the .ino files in the docs are confusing it. Otherwise, we can just put the pages in something arduino-lint does not probe (extras), that's probably easier ;). I also do not have strong feeling about that folder name. gh-pages might be more confusing than anything as it is also the name of a branch. Opinions? |
Yes, we won't have to do everything at once. We can still look into further automation (the .ino files, etc.) later. I suppose a folder below |
Added audio files
arduino-lint seems to be happy now! Reports not really but that's been a common issue for PR from a fork… I will do a bit of cleanup, both in the files and in the commits and will mark it as ready. |
Corrected doxyfile after move of website to extras Corrected action after move
Alright, I think this is looking good! You can check the deployment https://tomcombriat.github.io/Mozzi/ and the status of the actions on https://github.com/tomcombriat/Mozzi/ To not forget before merging (need to be at last minute):
On the longer run:
Edit:I had to fight a bit to get the "Modules" section of the documentation to show… The way I found around it is to use a previous Doxygen version… As a side effect, the theme returned to the previous one :) |
Retried removal of web in dox Another try
Hi Tom,
Let me know what I need to do when you're ready. |
Hi @sensorium ! So, the steps are as follow: on github and on Mozzi repo: Settings > Pages > Build and development > Choose "GitHub Actions" instead of "Deploy from a branch". Normally that should not break the website until something is pushed to main, but just to be sure I prefer to be around once you do that so maybe we can plan the transition for say, this weekend? (I'm on UTC+1). This also let a bit of time if @tfry-git wants to change something or hang it in order to have a closer look! |
so at 9pm here (utc+11), would it be 11am there? Will we try Saturday? |
Yup! If that is okay for you! I think it should go smooth ;) |
Hi @tomcombriat , I just made the change. What happens next? |
Hi @sensorium , I'll wait for these tests to finish and merge! (And hope that it behaves as expected ;) ) |
┈┈┈┈┈┈▕▔╲ |
This might be an answer to #289 .
Sorry for the enormous diff change, moving the whole site is quite some thing, but I actually thing some of it can be removed (I can safely remove the doc/html folder right?).
In a nutshell: this adds a workflow to automatically compile the doxygen sources, the website, and publishes it. All the sources are on the
master
branch.I have tested on my own fork first and changes both on the doxygen comments and on the website are correctly deployed.
For this to work, in the
Settings/pages
the source of deployment should be set toGitHub Actions
.I'll try to do a bit of cleanup also.