Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#106 Fix: could not compile in Gradle #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szead
Copy link

@szead szead commented Jun 5, 2023

Summary of this PR

  1. Gradle build failed
    a. missing curly bracket in build gradle
    b. serenity gradle plugin version was not found.
  2. Tests were not picked up by JUnit 5 runner due to the wrong artifact was used in Gradle.

Intended effect

It will build with Gradle again. Tests will run again with Gradle.

How should this be manually tested?

Just build the project first:
gradle clean build -x test
Then run the tests:
gradle clean test

Side effects

N/A

Documentation

N/A

Relevant tickets

#106
#105

Screenshots (if appropriate)

N/A

adamszentivanyi added 2 commits June 5, 2023 14:57
- curly bracket missing from plugins
- gradle plugin version was not found -> updated
- Using junit-vintage-engine to make test run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant