Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FlowControl: add FromStr impl #163

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jdswensen
Copy link
Contributor

Allow creating a 'FlowControl' enum from a 'str' type. This is useful when parsing strings from config files or command line arguments.

Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, could you add an entry to the changelog?

Allow creating a 'FlowControl' enum from a 'str' type. This is useful
when parsing strings from config files or command line arguments.
@jdswensen
Copy link
Contributor Author

Done!

Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin merged commit 84f6066 into serialport:main Mar 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants