Clean up integration tests #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly use the variables previously reported as unused. Also harmonize mutability of pseudo terminal pair.
Previously, tests were reported successful in every case. For example even with non-existent devices. So make the serial ports to use for testing explicit and actually check for success.
We have no actual hardware to test with in CI. This way hardware tests are at least built and the test code checked. Ignoring these tests clearly marks them during test execution as well. Passing the serial devices to use for testing via environment variables keeps a low profile. This is also a footgun when changing these devices. Improvements like conveniently using a config file are welcome. I found no straight forward solution for sharing the environment variables between different CI workflows and so they are duplicated with a note for now.
This surfaced with 1.80.0-nightly (05364cb2f 2024-05-03). According to a search in the targets mentioned in https://github.com/rust-lang/reference it always has been 'dragonfly' and just the warning is new.
We are running CI builds and tests for several of them, but not all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs cleans up some warnings from the doctests and makes tests using serial interfaces putting their cards on the table: The results of the operations under tests were just ignored beforehand and will be checked now.
Having the results checked now, requires the tests to use serial devices designated for testing. To keep a low profile, this is done by passing the devices via environment variables and rests requiring actual serial hardware can be ignored by default with the feature ignore-hardware-tests which is done in CI.