Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Sync for SerialPort trait #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

impl Sync for SerialPort trait #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2e0e7b
impl `Sync` for `SerialPort` trait
unlimitedsola Dec 12, 2024
953107a
Provide a permalink to the explanation in stdlib
unlimitedsola Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ impl SerialPortBuilder {
///
/// This trait is all that's necessary to implement a new serial port driver
/// for a new platform.
pub trait SerialPort: Send + io::Read + io::Write {
pub trait SerialPort: Send + Sync + io::Read + io::Write {
// Port settings getters

/// Returns the name of this port if it exists.
Expand Down
8 changes: 8 additions & 0 deletions src/windows/com.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,15 @@ pub struct COMPort {
port_name: Option<String>,
}

// The Windows `HANDLE` type is considered safe according to the standard library.
// See the explanation below in stdlib for more information:
// https://github.com/rust-lang/rust/blob/f4f0fafd0c7849e162eddbc69fa5fe82dbec28c7/library/std/src/os/windows/io/handle.rs#L111-L115
//
// In the future we might want to consider using `OwnedHandle` instead of `HANDLE` directly.
// At the time of writing, such work is blocked by this crate's MSRV (1.59.0) policy as
// `OwnedHandle` was stabilized in 1.63.0.
unsafe impl Send for COMPort {}
unsafe impl Sync for COMPort {}

impl COMPort {
/// Opens a COM port as a serial device.
Expand Down
Loading