Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): try replacing editorContent with normal child #4493

Open
wants to merge 14 commits into
base: staging
Choose a base branch
from

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Feb 13, 2025

(will do more testing once saving works ok in StorageFormat branch)

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ❌ Failed (Inspect) Feb 19, 2025 2:14pm

Copy link
Contributor

github-actions bot commented Feb 13, 2025

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 105.37 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/entity/create/[type]/[taxonomyId] 223.67 KB (🟢 -28 B) 329.04 KB
/entity/repository/add-revision/[...id] 223.33 KB (🟢 -29 B) 328.7 KB
/page/create 223.34 KB (🟢 -28 B) 328.71 KB
/taxonomy/term/create/[parent_id]/[id] 223.04 KB (🟢 -28 B) 328.41 KB
/user/settings 225.06 KB (🟢 -41 B) 330.43 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@hejtful hejtful changed the title refactor(editor): try repacing editorContent with normal child refactor(editor): try replacing editorContent with normal child Feb 17, 2025
@elbotho elbotho marked this pull request as ready for review February 18, 2025 10:28
Base automatically changed from refactor/remove-entityType to refactor/adjust-frontent-to-new-editor-storage-format February 18, 2025 10:42
Base automatically changed from refactor/adjust-frontent-to-new-editor-storage-format to staging February 18, 2025 17:17
@elbotho
Copy link
Member Author

elbotho commented Feb 19, 2025

@hejtful I added some adaptations and some more refactoring. Mind having another look?

Copy link
Contributor

@hejtful hejtful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the benefits of this refactoring are, but everything works, so your call to merge or not.

refactor(template-plugins): unify field names in template plugins to simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants