Add Mangohud and its dependencies #503
Conversation
| summary : The OpenGL Extension Wrangler Library | ||
| description : | | ||
| The OpenGL Extension Wrangler Library (GLEW) is a cross-platform open-source C/C++ extension loading library. GLEW provides efficient run-time mechanisms for determining which OpenGL extensions are supported on the target platform. OpenGL core and extension functionality is exposed in a single header file. | ||
| license : |
There was a problem hiding this comment.
Licenses need to be in SPDX identifier format. Please check against the following website: https://spdx.org/licenses/
| - pkgconfig(glu) | ||
| - pkgconfig(x11) | ||
| setup : | | ||
| %patch %(pkgdir)/glew-install.patch |
There was a problem hiding this comment.
What are these patches for? There's no comment in the header of the patches or before the patch lines indicating what exactly they are for. Are they even applicable to serpent or did you just copy them from elsewhere?
| %patch %(pkgdir)/glew-install.patch | ||
| %patch %(pkgdir)/egl+glx.patch | ||
| sed -i 's|lib64|lib|' config/Makefile.linux |
There was a problem hiding this comment.
These seds should be a patch
| - BSD | ||
| - GPL | ||
| builddeps : | ||
| - binary(cc) |
There was a problem hiding this comment.
You probably don't need an explicit binary(cc) dependency
| mv bin/glewinfo bin/eglewinfo | ||
| install : | | ||
| %make GLEW_DEST="%(installroot)/usr" STRIP= SYSTEM=linux-egl install | ||
| install -D -m755 -t "%(installroot)/usr/bin" bin/eglewinfo bin/glxewinfo bin/visualinfo |
There was a problem hiding this comment.
| - pkgconfig(xcursor) | ||
| - pkgconfig(xi) | ||
| setup : | | ||
| %cmake |
There was a problem hiding this comment.
I notice this is building the static library (the .a file) and not the shared library. You're probably missing this cmake arg: -DBUILD_SHARED_LIBS=ON
| description : | | ||
| A Vulkan and OpenGL overlay for monitoring FPS, temperatures, CPU/GPU load and more. | ||
| license : MIT | ||
| toolchain : gnu |
There was a problem hiding this comment.
Why? Is there a build failure? What is it? Such information should be in the recipe as a comment.
| release : 1 | ||
| homepage : https://github.com/nlohmann/json | ||
| upstreams : | ||
| - git|https://github.com/nlohmann/json.git : 9cca280a4d0ccf0c08f47a99aa71d1b0e52f8d03 |
There was a problem hiding this comment.
On Solus we build this with a source archive, is there some reason you need a git checkout? Source archives are strongly preferred when possible
| license : MIT | ||
| setup : | | ||
| mkdir -vp build-test/ | ||
| mv -v %(workdir)/../v3.1.0.tar.gz/ build-test/json_test_data/ |
There was a problem hiding this comment.
Take a look at the gcc recipe. It's possible to add some extra fields to the upstream section which will cause it to extract to a directory of your choice.
| %cmake | ||
| build : | | ||
| %cmake_build | ||
| ctest --test-dir %(workdir) --output-on-failure |
There was a problem hiding this comment.
Tests should be in a specific check phase. Look at the gzip recipe for an example.
This will add Mangohud and its dependencies