Single version Variable for both charts and docker images (#36)

* use a single version through out Signed-off-by: Tarun Pothulapati <[email protected]> * remove unnecessary rm Signed-off-by: Tarun Pothulapati <[email protected]>
servicemeshinterface · Aug 23, 2019 · 46754df · 46754df
1 parent f2ab00e
commit 46754df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -66,6 +66,9 @@ ifndef CIRCLE_TAG
 endif
 	cp -R chart tmp/smi-metrics
 	sed -i.bak 's/CHART_VERSION/${VERSION}/g' tmp/smi-metrics/Chart.yaml
+	for fname in $$(grep -rnl '$*' tmp/smi-metrics); do \
+		sed -i.bak 's/VERSION/${CIRCLE_TAG}/g' $$fname; \
+	done
 	helm package tmp/smi-metrics -d tmp --save=false
 	rm -rf tmp/smi-metrics/
 

diff --git a/chart/Chart.yaml b/chart/Chart.yaml
@@ -1,5 +1,5 @@
 apiVersion: v1
-appVersion: "0.1"
+appVersion: CHART_VERSION
 description: Provider for metrics.smi-spec.io
 name: smi-metrics
 version: CHART_VERSION
diff --git a/chart/values.yaml b/chart/values.yaml
@@ -1,7 +1,7 @@
 replicaCount: 1
 
 image:
-  name: thomasr/smi-metrics:v1alpha1-0.1
+  name: deislabs/smi-metrics:VERSION
   pullPolicy: IfNotPresent
 
 config: