Skip to content

Commit

Permalink
#cnsqa-1672 add new AfterResponseSend event (#599)
Browse files Browse the repository at this point in the history
#cnsqa-1672 add new AfterResponseSend event
  • Loading branch information
lukasPan authored Jan 29, 2025
1 parent 093138d commit 2cf811d
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 7 deletions.
6 changes: 6 additions & 0 deletions .changeset/loud-adults-sparkle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@ima/hmr-client": patch
"@ima/server": patch
---

`@esmj/emitter` dependency updated.
5 changes: 5 additions & 0 deletions .changeset/sour-glasses-travel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ima/server": minor
---

Added new `AfterResponseSend` event.
11 changes: 6 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/hmr-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"webpack": "^5.70.0"
},
"dependencies": {
"@esmj/emitter": "^0.3.0"
"@esmj/emitter": "^0.4.3"
}
}
1 change: 1 addition & 0 deletions packages/server/lib/emitter.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const Event = {
BeforeResponse: 'ima.server.beforeResponse',
Response: 'ima.server.response',
AfterResponse: 'ima.server.afterResponse',
AfterResponseSend: 'ima.server.afterResponseSend',

CreateBootConfig: 'ima.server.bootConfig',
CreateImaApp: 'ima.server.createApp',
Expand Down
7 changes: 7 additions & 0 deletions packages/server/lib/factory/serverAppFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ module.exports = function serverAppFactory({
}

event = await emitter.emit(Event.AfterResponse, event);
await emitter.emitParallel(Event.AfterResponseSend, event);

return event;
}
Expand Down Expand Up @@ -205,6 +206,12 @@ module.exports = function serverAppFactory({

res.status(context.response.status);
res.send(context.response.content);

try {
await emitter.emitParallel(Event.AfterResponseSend, event);
} catch (error) {
logger.error('Error in AfterResponseSend', { error });
}
}

return event.context.response;
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"test": "jest"
},
"dependencies": {
"@esmj/emitter": "^0.3.0",
"@esmj/emitter": "^0.4.3",
"@esmj/monitor": "^0.5.3",
"chalk": "^4.1.2",
"ejs": "^3.1.6",
Expand Down
1 change: 1 addition & 0 deletions packages/server/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ declare module '@ima/server' {
BeforeResponse = 'ima.server.beforeResponse',
Response = 'ima.server.response',
AfterResponse = 'ima.server.afterResponse',
AfterResponseSend = 'ima.server.afterResponseSend',

CreateBootConfig = 'ima.server.bootConfig',
CreateImaApp = 'ima.server.createApp',
Expand Down

0 comments on commit 2cf811d

Please sign in to comment.