fix for assignRecursively - use deepClone for arrays instead of slice

seznam · Dec 20, 2023 · c0f0359 · c0f0359
1 parent 955e3eb
commit c0f0359
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/slow-brooms-accept.md b/.changeset/slow-brooms-accept.md
@@ -0,0 +1,5 @@
+---
+"@ima/helpers": patch
+---
+
+fix for assignRecursively - use deepClone for arrays instead of slice, so any modifications in the assignRecursively result newly NOT mutate the other results
diff --git a/packages/helpers/src/__tests__/indexSpec.js b/packages/helpers/src/__tests__/indexSpec.js
@@ -12,6 +12,15 @@ describe('helper', () => {
       );
       expect(target).toStrictEqual({ a: 3, b: { c: 5, d: [5] }, d: 4 });
     });
+
+    it('should clone array to the target object', () => {
+      const arrayWithObject = [{ x: 1 }];
+      let target = {};
+      helpers.assignRecursively(target, { a: arrayWithObject, d: 4 });
+
+      expect(target).toStrictEqual({ a: arrayWithObject, d: 4 });
+      expect(arrayWithObject[0]).not.toBe(target.a[0]);
+    });
   });
 
   describe('assignRecursivelyWithTracking', () => {

diff --git a/packages/helpers/src/index.js b/packages/helpers/src/index.js
@@ -13,7 +13,7 @@ function assign(target, source, parentField = null, ignoreMeta = true) {
     fieldList.push(fieldPath);
 
     if (value instanceof Array) {
-      target[field] = value.slice();
+      target[field] = clone(value);
     } else if (
       value instanceof Object &&
       !(value instanceof Function) &&