-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define date format in templates instead of index.php #169
Conversation
@alexisju You're right, I need to look more at my IDE's log. Also I forgot the time in QRCode title. I can do this
However, what is the point to |
Mind that the QR code will be moved as a plugin (part of #164) |
@alexisju comment has disappeared because it was probably a commit comment, and I rebased the commit. But the warning are gone, and I've removed htmlspecialchars on timestamps since they're not even user input. @nodiscc it might be, but since the plugin system is not merged I've to assume the QRCode is still in core templates. |
Sure. |
Mostly ok to merge, @ArthurHoaro are you sure it's ok removing Maybe it's safer to at least warn them, some time before this change? |
Well, that's actually the point of this PR: switch date formatting from index.php to templates. So yes, third party templates will have to make an update. I don't see this as an issue because those themes support are in a separate milestone. But we can obviously warn them. |
Merged in bec1870 |
It allows theme creators to display dates the way they want to by playing with
strftime
function parameter.cf #144