Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write in plugin configuration files through pluginsadmin.html #471

Closed
wants to merge 2 commits into from

Conversation

ArthurHoaro
Copy link
Member

Fixes #464

By design, plugins/<plugin>/config.php overrides config.php for this specific plugin. But when you save settings in the plugin admin page, the plugin config file is not set (it only has effect on global config.php).

It's a bit complicated in index.php because plugin settings share the same array and I didn't want to change pluginsadmin.html and existing settings.

@ArthurHoaro ArthurHoaro added bug it's broken! plugin bells and whistles in review labels Feb 10, 2016
@ArthurHoaro ArthurHoaro self-assigned this Feb 10, 2016
@ArthurHoaro ArthurHoaro added this to the 0.6.4 milestone Feb 10, 2016
@virtualtam
Copy link
Member

Not sure if it's a good idea to spread configuration over multiple files; this means users need to care about file/folder permissions for every installed/enabled plugin, instead of just the data folder.

Maybe it'd be worth raising an issue to switch to a plain INI file file and use a dedicated section for each plugin?

@ArthurHoaro
Copy link
Member Author

Maybe it'd be worth raising an issue to switch to a plain INI file file and use a dedicated section for each plugin?

INI configuration files are not suited for configuration with array. If we had to move, I'd rather move to JSON or YAML. There was a PR about moving to YAML, which was finally not merged.

Not sure if it's a good idea to spread configuration over multiple files; this means users need to care about file/folder permissions for every installed/enabled plugin, instead of just the data folder.

Well, I agree. The downside is that it'll be slightly harder to have a default settings set, but definitely manageable. Should we open an issue to remove this feature?

@virtualtam
Copy link
Member

Discussion opened @ #489 ;-)

@ArthurHoaro ArthurHoaro modified the milestones: 0.7.0, 0.6.4 Feb 25, 2016
@ArthurHoaro
Copy link
Member Author

Pushed to 0.7 as the conf discussion is idling.

@ArthurHoaro ArthurHoaro modified the milestones: 0.7.0, 0.7.1 May 14, 2016
@virtualtam virtualtam mentioned this pull request May 19, 2016
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! in review plugin bells and whistles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants