Fix ansible-lint rule violations

add_block_rule.yml

@@ -3,7 +3,7 @@
   hosts: localhost
   gather_facts: false
   vars:
-    actiontaken: 'drop'
+    actiontaken: drop
 
   roles:
     - create_rule

collections/requirements.yml

@@ -1,5 +1,5 @@
+---
 collections:
-
   - name: ibm.qradar
 
   - name: paloaltonetworks.panos

remove_log_forwarding_snort.yml

@@ -3,8 +3,8 @@
   hosts: snort.shadowman.dev
   gather_facts: false
   vars:
-    ids_provider: "snort"
-    ids_config_provider: "snort"
+    ids_provider: snort
+    ids_config_provider: snort
     ids_config_remote_log: false
     ids_config_remote_log_destination: "{{ hostvars['qradar.shadowman.dev']['ip_addr'] }}"
     ids_config_remote_log_procotol: udp

roles/create_rule/defaults/main.yml

@@ -1,14 +1,14 @@
 ---
-rule_name: 'Ansible Attacker Rule'
-description: 'An Ansible attacker rule'
-source_zone: ['any']
-destination_zone: ['any']
+rule_name: Ansible Attacker Rule
+description: An Ansible attacker rule
+source_zone: [any]
+destination_zone: [any]
 source_ip: "{{ hostvars['attacker.shadowman.dev']['ip_addr'] }}"
-source_user: ['any']
+source_user: [any]
 destination_ip: "{{ hostvars['snort.shadowman.dev']['ip_addr'] }}"
-category: ['any']
-application: ['any']
-service: ['any']
-hip_profiles: ['any']
-actiontaken: 'allow'
-state: 'present'
+category: [any]
+application: [any]
+service: [any]
+hip_profiles: [any]
+actiontaken: allow
+state: present

roles/delete_rule/defaults/main.yml

@@ -1,3 +1,3 @@
 ---
-rule_name: 'Ansible Attacker Rule'
-state: 'absent'
+rule_name: Ansible Attacker Rule
+state: absent

roles/disable_log_forwarding_palo/tasks/main.yml

@@ -1,11 +1,11 @@
 ---
 - name: Remove palo remote logging from QRadar
   ibm.qradar.qradar_log_source_management:
-    name: "Palo Alto rsyslog source - {{ hostvars['palo.shadowman.dev']['ip_addr'] }}"
-    type_name: "Palo Alto PA Series"
+    name: Palo Alto rsyslog source - {{ hostvars['palo.shadowman.dev']['ip_addr'] }}
+    type_name: Palo Alto PA Series
     state: absent
-    description: "Palo Alto rsyslog source"
-    identifier: "palo.shadowman.dev"
+    description: Palo Alto rsyslog source
+    identifier: palo.shadowman.dev
 
 - name: Remove the new log source
   ibm.qradar.qradar_deploy:

roles/disable_log_forwarding_snort/tasks/main.yml

@@ -1,11 +1,11 @@
 ---
 - name: Remove snort remote logging from QRadar
   ibm.qradar.qradar_log_source_management:
-    name: "Snort rsyslog source - {{ hostvars['snort.shadowman.dev']['ip_addr'] }}"
-    type_name: "Snort Open Source IDS"
+    name: Snort rsyslog source - {{ hostvars['snort.shadowman.dev']['ip_addr'] }}
+    type_name: Snort Open Source IDS
     state: absent
-    description: "Snort rsyslog source"
-    identifier: "snort"
+    description: Snort rsyslog source
+    identifier: snort
 
 - name: Remove the new log source
   ibm.qradar.qradar_deploy:

roles/enable_log_forwarding_palo/tasks/main.yml

@@ -1,11 +1,11 @@
 ---
 - name: Add remote logging to QRadar
   ibm.qradar.qradar_log_source_management:
-    name: "Palo Alto rsyslog source - {{ hostvars['palo.shadowman.dev']['ip_addr'] }}"
-    type_name: "Palo Alto PA Series"
+    name: Palo Alto rsyslog source - {{ hostvars['palo.shadowman.dev']['ip_addr'] }}
+    type_name: Palo Alto PA Series
     state: present
-    description: "Palo Alto rsyslog source"
-    identifier: "palo.shadowman.dev"
+    description: Palo Alto rsyslog source
+    identifier: palo.shadowman.dev
 
 - name: Deploy the new log source
   ibm.qradar.qradar_deploy:

roles/enable_log_forwarding_snort/tasks/main.yml

@@ -1,11 +1,11 @@
 ---
 - name: Add remote logging to QRadar
   ibm.qradar.qradar_log_source_management:
-    name: "Snort rsyslog source - {{ hostvars['snort.shadowman.dev']['ip_addr'] }}"
-    type_name: "Snort Open Source IDS"
+    name: Snort rsyslog source - {{ hostvars['snort.shadowman.dev']['ip_addr'] }}
+    type_name: Snort Open Source IDS
     state: present
-    description: "Snort rsyslog source"
-    identifier: "snort"
+    description: Snort rsyslog source
+    identifier: snort
 
 - name: Deploy the new log source
   ibm.qradar.qradar_deploy:

roles/ids_config/defaults/main.yml

@@ -2,7 +2,7 @@
 # defaults file for snort-config
 #
 
-ids_provider: "snort"
+ids_provider: snort
 
 ids_provider_list:
   - snort

roles/ids_config/tasks/main.yml

@@ -1,9 +1,8 @@
 ---
-
 - name: Find snort rules
   ansible.builtin.find:
     paths: "{{ ids_config_snort_rules_dir }}"
-    patterns: '*.rules'
+    patterns: "*.rules"
     recurse: true
   register: ids_config_snort_rules_files
 
@@ -13,7 +12,7 @@
     dest: /etc/snort/snort.conf
     owner: root
     group: root
-    mode: '0644'
+    mode: "0644"
   notify: Restart snort
 
 - name: Enable remote logging
@@ -26,7 +25,7 @@
         backup: true
         owner: root
         group: root
-        mode: '0644'
+        mode: "0644"
       notify:
         - Restart rsyslog
 
@@ -46,7 +45,7 @@
         backup: true
         owner: root
         group: root
-        mode: '0644'
+        mode: "0644"
       when: st.stat.exists
 
     - name: Remove ids_config_snort_rsyslog.conf rsyslog config

roles/remove_log_forwarding_palo/tasks/main.yml

@@ -6,7 +6,7 @@
       username: "{{ palo_username }}"
       password: "{{ palo_password }}"
     names:
-      - "Ansible Attacker Rule"
+      - Ansible Attacker Rule
   register: ruleresults
 
 - name: Remove Forwarding Rule
@@ -35,8 +35,8 @@
       ip_address: "{{ palo_ip_address }}"
       username: "{{ palo_username }}"
       password: "{{ palo_password }}"
-    name: "QRadar Shadowman"
-    log_forwarding_profile: 'QRadar Shadowman'
+    name: QRadar Shadowman
+    log_forwarding_profile: QRadar Shadowman
     state: absent
 
 - name: Remove Log Forwarding Profile
@@ -45,7 +45,7 @@
       ip_address: "{{ palo_ip_address }}"
       username: "{{ palo_username }}"
       password: "{{ palo_password }}"
-    name: "QRadar Shadowman"
+    name: QRadar Shadowman
     state: absent
 
 - name: Remove Syslog server Palo
@@ -55,8 +55,8 @@
       username: "{{ palo_username }}"
       password: "{{ palo_password }}"
     state: absent
-    name: "QRadar Shadowman"
-    syslog_profile: "QRadar Shadowman"
+    name: QRadar Shadowman
+    syslog_profile: QRadar Shadowman
     server: "{{ hostvars['qradar.shadowman.dev']['ip_addr'] }}"
 
 - name: Remove Syslog profile Palo
@@ -65,7 +65,7 @@
       ip_address: "{{ palo_ip_address }}"
       username: "{{ palo_username }}"
       password: "{{ palo_password }}"
-    name: "QRadar Shadowman"
+    name: QRadar Shadowman
     state: absent
 
 - name: Commit Changes

roles/security_hostroutes/tasks/add_hostroutes_from_attacker_to_checkpoint.yml

@@ -1,22 +1,23 @@
 ---
-- name: "Add gw route on attacker node {{ inventory_hostname }}"
+- name: Add gw route on attacker node {{ inventory_hostname }}
   ansible.builtin.lineinfile:
     path: /etc/sysconfig/network-scripts/route-ens3
     line: "{{ hostvars[inventory_hostname | regex_replace('attacker.shadowman.dev', 'palo.shadowman.dev')]['ip_addr'] }} dev ens3"
     create: true
     owner: root
     group: root
-    mode: '0644'
+    mode: "0644"
   notify:
     - Restart-network
 
-- name: "Add snort route on attacker node {{ inventory_hostname }}"
+- name: Add snort route on attacker node {{ inventory_hostname }}
   ansible.builtin.lineinfile:
     path: /etc/sysconfig/network-scripts/route-ens3
-    line: "{{ hostvars[inventory_hostname | regex_replace('attacker.shadowman.dev', 'snort.shadowman.dev')]['ip_addr'] }} via {{ hostvars[inventory_hostname | regex_replace('attacker.shadowman.dev', 'palo.shadowman.dev')]['ip_addr'] }} dev ens3 metric 5"
+    line: "{{ hostvars[inventory_hostname | regex_replace('attacker.shadowman.dev', 'snort.shadowman.dev')]['ip_addr'] }} via {{ hostvars[inventory_hostname | regex_replace('attacker.shadowman.dev',
+      'palo.shadowman.dev')]['ip_addr'] }} dev ens3 metric 5"
     create: true
     owner: root
     group: root
-    mode: '0644'
+    mode: "0644"
   notify:
     - Restart-network

roles/security_hostroutes/tasks/add_hostroutes_from_snort_to_checkpoint.yml

@@ -1,22 +1,23 @@
 ---
-- name: "Add gw route on snort node {{ inventory_hostname }}"
+- name: Add gw route on snort node {{ inventory_hostname }}
   ansible.builtin.lineinfile:
     path: /etc/sysconfig/network-scripts/ifcfg-ens3
     line: "{{ hostvars[inventory_hostname | regex_replace('snort.shadowman.dev', 'palo.shadowman.dev')]['ip_addr'] }} dev ens3"
     create: true
     owner: root
     group: root
-    mode: '0644'
+    mode: "0644"
   notify:
     - Restart-network
 
-- name: "Add attacker route on snort node {{ inventory_hostname }}"
+- name: Add attacker route on snort node {{ inventory_hostname }}
   ansible.builtin.lineinfile:
     path: /etc/sysconfig/network-scripts/ifcfg-ens3
-    line: "{{ hostvars[inventory_hostname | regex_replace('snort.shadowman.dev', 'attacker.shadowman.dev')]['ip_addr'] }} via {{ hostvars[inventory_hostname | regex_replace('snort.shadowman.dev', 'palo.shadowman.dev')]['ip_addr'] }} dev ens3 metric 5"
+    line: "{{ hostvars[inventory_hostname | regex_replace('snort.shadowman.dev', 'attacker.shadowman.dev')]['ip_addr'] }} via {{ hostvars[inventory_hostname | regex_replace('snort.shadowman.dev',
+      'palo.shadowman.dev')]['ip_addr'] }} dev ens3 metric 5"
     create: true
     owner: root
     group: root
-    mode: '0644'
+    mode: "0644"
   notify:
     - Restart-network