v1.1 with new mocky identifier #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils` - This string can be provided by the feature module itself since it's heavily relevant to the feature module and not considered a widely used string - However, for better maintenance it's advised all resources to be provided by the main app when possible. But for this one, considering the feature module location is also valid
Sort by id lastly in ascending order if other sorting fail
- Test runs on local machine, while failing on CI pipeline. I'm assuming the CI workflow is slower in processing and there's also a 700ms navigation transition between Books screen to Details screen and that might cause some delay in displaying the details screen since on emulator's end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Changes:
Fixed and brought From previous PR: #18
Extract string resource related to feature module "feature"book_details
This string can be provided by the feature module itself since it's heavily relevant to the feature module and not considered a widely used string
However, for better maintenance it's always advised all resources to be provided by the main app when possible. But for this one, considering the feature module location is also valid
Sort books by release date provided
Sort by Id : Sort by id in ascending order if other sorting cases fail