Skip to content

Commit

Permalink
ci: Fix workflow events
Browse files Browse the repository at this point in the history
This was found by auditing workflows based on research published here:

https://github.com/joeyparrish/workflow-cheat-sheet

The research was prompted by a workflow bug in Shaka Streamer
  • Loading branch information
joeyparrish committed Nov 5, 2024
1 parent 111cbec commit bcdf350
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ jobs:
monorepo-tags: true

- name: Checkout code
uses: actions/checkout@v4
with:
ref: refs/tags/${{ steps.release.outputs.tag_name }}
if: steps.release.outputs.releases_created
uses: actions/checkout@v2

- name: Setup Node.js
if: steps.release.outputs.releases_created
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:

- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.ref }}

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
Expand Down

0 comments on commit bcdf350

Please sign in to comment.