Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chromeos): Fix node-ssh exit code interpretation #92

Merged
merged 2 commits into from
May 15, 2024

Conversation

joeyparrish
Copy link
Member

Since upgrading node-ssh, we sometimes get an exit code of 0, other times an exit code of null. This makes the tool more flexible in interpreting those codes.

Since upgrading node-ssh, we sometimes get an exit code of 0, other times an exit code of null.  This makes the tool more flexible in interpreting those codes.
@joeyparrish joeyparrish merged commit aae4728 into shaka-project:main May 15, 2024
11 checks passed
@joeyparrish joeyparrish deleted the chromeos-ssh-exit-codes branch May 15, 2024 22:14
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants