Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
shalberd committed Aug 2, 2024
1 parent 8f2102e commit a7f9f24
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func CompareNotebookNetworkPolicies(np1 netv1.NetworkPolicy, np2 netv1.NetworkPo
}

// NewNotebookNetworkPolicy defines the desired network policy for Notebook port
func NewNotebookNetworkPolicy(notebook *nbv1.Notebook, log logr.Logger, namespace: string) *netv1.NetworkPolicy {
func NewNotebookNetworkPolicy(notebook *nbv1.Notebook, log logr.Logger, namespace string) *netv1.NetworkPolicy {
npProtocol := corev1.ProtocolTCP
if err != nil {

Check failure on line 133 in components/odh-notebook-controller/controllers/notebook_network.go

View workflow job for this annotation

GitHub Actions / govulncheck (components/odh-notebook-controller)

undefined: err
log.Error(err, "Get controller / main namespace error, not creating NetworkPolicy resource that allows all ingress traffic to the oauth port of a notebook from main namespace")

Check failure on line 134 in components/odh-notebook-controller/controllers/notebook_network.go

View workflow job for this annotation

GitHub Actions / govulncheck (components/odh-notebook-controller)

undefined: err
Expand Down

0 comments on commit a7f9f24

Please sign in to comment.