Cleanup

requirements-dev.txt

@@ -1,4 +1,3 @@
 pytest
 setuptools
 wheel
-shutil

src/terrapyne/logging.py

@@ -332,3 +332,5 @@ def cli_log_config(
             raise ValueError("A critical message from an exception")
         except Exception as exc:
             logging.critical(str(exc), exc_info=True)
+
+# https://gist.github.com/eblocha/fba1c0e2b49333607c4a2d7492f7491c

src/terrapyne/terrapyne.py

@@ -6,8 +6,8 @@
 from functools import cached_property
 from pathlib import Path
 from shutil import which
-from subprocess import Popen, PIPE, STDOUT
-from typing import Union, Tuple, Any
+from subprocess import Popen, PIPE
+from typing import Tuple, Any
 import logging as log
 import os
 import re
@@ -45,7 +45,7 @@ def __init__(self, required_version=None):
 
     @cached_property
     def version(self):
-        stdout, stderr, exit_code = self.exec(
+        stdout, _, _ = self.exec(
             cmd=["version"],
         )
         result = (
@@ -85,7 +85,7 @@ def plan(self, args=None) -> Tuple[str, str, int]:
 
     def apply(self, args=None) -> Tuple[str, str, int]:
         if not os.path.exists(self.tfplan_name):
-            self.init(args=[f"-backend=false"])
+            self.init(args=["-backend=false"])
             self.plan(args=[f"-out={self.tfplan_name}"])
         return self.exec(
             cmd=["apply", *(args or [])],
@@ -199,7 +199,7 @@ def exec(
         log.debug(f"stderr: {stderr}")
         log.debug(f"exit_code: {exit_code}")
 
-        if ignore_exit_code is not True and exit_code != 0:
+        if ignore_exit_code is not True and exit_code != expect_exit_code:
             raise Exception(f"[Error]: exit_code {exit_code} running '{cmd}': {stderr}")
 
         if expect_stdout is not None: