Added a new option for credits saving #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option for credits saving: 'Save on each transaction and on player disconnect'
This is meant to fix an exploit where players would intentionally crash the server to duplicate credits.
Since crashing the server doesn't call OnClientDisconnect(), with some knowledge you could duplicate credits. I won't exactly tell how it works because this can be used on pretty much every store/shop/credits system.
This might be heavier for the server,
please only change if you experience recurring crashes and are afraid of potential credits loss/exploits due to this.but I advise running this anyways.Player disconnect saves could be removed since we already save on each transaction, but I left it as it was since we never know.