-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network requests #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing very testable for now, from a code point of view looks fine, runtime test will be done at wire up time!
A few suggestions though, that can be done in a follow up if needed
@@ -0,0 +1,60 @@ | |||
// Subset of web caip constants with Chainfli-supported assets only | |||
// We need to redeclare things here as @shapeshiftoss/caip is actually a monorepo project and not published on npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way to make it exported from our monorepo so we can consume it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for the time being unfortunately, unless we start publishing packages again, which is a story for another day but would indeed make things a lot easier!
Description
Implements unwired-up network requests for the app
Issue