Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network requests #42

Merged
merged 14 commits into from
Jan 29, 2025
Merged

feat: network requests #42

merged 14 commits into from
Jan 29, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 28, 2025

Description

Implements unwired-up network requests for the app

  • CG market-data
  • CF assets
  • CF quote
  • CF swap intent
  • CF status

Issue

package.json Outdated Show resolved Hide resolved
@gomesalexandre gomesalexandre marked this pull request as ready for review January 28, 2025 16:08
Copy link
Contributor

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing very testable for now, from a code point of view looks fine, runtime test will be done at wire up time!

A few suggestions though, that can be done in a follow up if needed

src/config/react-query.ts Outdated Show resolved Hide resolved
src/constants/caip.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,60 @@
// Subset of web caip constants with Chainfli-supported assets only
// We need to redeclare things here as @shapeshiftoss/caip is actually a monorepo project and not published on npm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to make it exported from our monorepo so we can consume it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the time being unfortunately, unless we start publishing packages again, which is a story for another day but would indeed make things a lot easier!

src/queries/chainflip/assets.ts Outdated Show resolved Hide resolved
src/queries/chainflip/quote.ts Outdated Show resolved Hide resolved
@gomesalexandre gomesalexandre merged commit a95eba2 into develop Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network requests
2 participants