Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet button stale ENS addies #8536

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: wallet button stale ENS addies #8536

merged 1 commit into from
Jan 13, 2025

Conversation

gomesalexandre
Copy link
Contributor

Description

Fixes ENS reactivity/reset issues by using a react-query, or rather using wagmi's useEnsName which does precisely that under the hood for us, cleaning things up a bit while at it.

Issue (if applicable)

closes #8535

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • ENS is happy for EVM wallets with ENS
  • Going from an EVM wallet with ENS to a Ledger without ENS doesn't display a stale ENS

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • This diff

https://jam.dev/c/56cda424-3f1b-4e4e-baad-c9a3a23e7f42

  • develop

https://jam.dev/c/4635c6ea-dc26-4222-bec6-8c10f62345e1

Sorry, something went wrong.

@gomesalexandre gomesalexandre requested a review from a team as a code owner January 10, 2025 12:30
@gomesalexandre gomesalexandre changed the title fix: walletbutton stale ENS addies fix: wallet button stale ENS addies Jan 10, 2025
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Ledger is now called "Ledger" after changing from an ENS account 😌

Screenshot 2025-01-13 at 13 31 12

@0xApotheosis 0xApotheosis merged commit b25b002 into develop Jan 13, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the fix_stale_ens branch January 13, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale ENS when going from an EVM wallet to a Ledger without ENS
2 participants