-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v1.734.0 #8572
Draft
NeOMakinG
wants to merge
14
commits into
main
Choose a base branch
from
release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: release v1.734.0 #8572
+743
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip: dont set wallet context device id until the wallet is fully connected * fix: reset deviceId when disconnecting wallet * chore: cleanup * fix: prompt user to open native wallet on reload * chore: move early return before isDemoWallet check * chore: use better checks on receiveAddress react query skipToken * chore: memoize wallet get from keyring * chore: dont try respond to events for empty device ID * chore: remove redundant coalesce * chore: better typeof of SET_NATIVE_PENDING_DEVICE_ID action * chore: cleanup logging of wallet ids
* wip: you saved card with button * deps: install react-canvas-confetti * wip: confetti working * wip: confetti done * feat: wire up amount to YouSaved * feat: implement fee saving in YouSaved * feat: redirect to trade input when clicking buy fox * feat: add you could have saved component * feat: share button for YouSaved * feat: wire up actual fee amounts to UI * chore: remove scaffold for UI dev * chore: remove redundant comments --------- Co-authored-by: NeOMakinG <[email protected]>
Co-authored-by: woody <[email protected]>
#8564) * fix: corrupted related asset index during regen * chore: cleanup and comments * feat: regenerate asset data 01/14/2025 * chore: cleanup testing script
Co-authored-by: gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: trade impact is including protocol fees for chainflip (#8556)
fix: jupiter more accurate price impact (#8566)
fix: ensure receiveAddress query -> string | null (#8565)
fix: undefined useAccountsFetch queryFn return (#8543)
feat: enable base on thorchain (#8563)
fix: random assets showing as "related" after re-generating asset data (#8564)
feat: deprioritize happy quotes without network fees (#8550)
feat: fox savings summary on trade success (#8531)
fix: wallet state corruption round 4 (#8519)
fix: import dead click on wallet modal (#8555)
fix: increase settings modal size (#8551)
feat: disable preview and warn users of unsupported ChainFlip BTC sells for KK (#8506)
fix: count both defi & asset balances (#8545)
fix: use nth-of-type selector (#8544)