Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: turn on new wallet flow flag in devish envs #8648

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: turn on new wallet flow flag in devish envs #8648

merged 1 commit into from
Jan 22, 2025
+2 −0

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 22, 2025 •
edited
Loading

Description

i.e local and upstream develop - now that all wallets are implemented, we should start dogfeeding this while developping.

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low - dev envs only for testing purposes.

Testing

Engineering

  • run yarn env dev && yarn dev
  • Ensure new wallet flow is there

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • None

Screenshots (if applicable)

image

@gomesalexandre gomesalexandre marked this pull request as ready for review January 22, 2025 15:00
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 22, 2025 15:00
NeOMakinG
NeOMakinG approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@NeOMakinG NeOMakinG merged commit 314349a into develop Jan 22, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the feat_new_wallet_flow_dev branch January 22, 2025 16:42
@0xApotheosis 0xApotheosis mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @NeOMakinG