added validator for feasible space distribution

Signed-off-by: Shashank Mittal <[email protected]> validation logic fixed added unit test added unit test for valid distribution requested changes made Update pkg/webhook/v1beta1/experiment/validator/validator.go Co-authored-by: Yuki Iwai <[email protected]> fmt
shashank-iitbhu · Aug 18, 2024 · 328559f · 328559f
1 parent 51b246f
commit 328559f
Show file tree

Hide file tree

Showing 7 changed files with 132 additions and 94 deletions.
diff --git a/pkg/apis/controller/experiments/v1beta1/experiment_types.go b/pkg/apis/controller/experiments/v1beta1/experiment_types.go
@@ -221,6 +221,7 @@ const (
 	DistributionLogUniform Distribution = "logUniform"
 	DistributionNormal     Distribution = "normal"
 	DistributionLogNormal  Distribution = "logNormal"
+	DistributionUnknown    Distribution = "unknown"
 )
 
 // TrialTemplate describes structure of trial template

diff --git a/pkg/apis/manager/v1beta1/api.pb.go b/pkg/apis/manager/v1beta1/api.pb.go
diff --git a/pkg/apis/manager/v1beta1/api.proto b/pkg/apis/manager/v1beta1/api.proto
@@ -105,6 +105,7 @@ enum Distribution {
     LOG_UNIFORM = 1;
     NORMAL = 2;
     LOG_NORMAL = 3;
+    DISTRIBUTION_UNKNOWN = 4;
 }
 
 /**